hashhar opened a new pull request #577: URL: https://github.com/apache/maven-mvnd/pull/577
Let the JVM decide the max heap size instead of using hardcoded defaults to match the behaviour of vanilla Maven. Fixes https://github.com/apache/maven-mvnd/issues/560 I tried adding a test like: ```java Client client = ClientFactory.create(parameters.withJdkJavaOpts("-Xmx200M -XshowSettings")); final TestClientOutput output = new TestClientOutput(); client.execute(output, "verify").assertSuccess(); output.assertContainsMatchingSubsequence("Max. Heap Size: 200.00M"); ``` But it fails. It seems the TestClientOutput only contains messages from Maven itself - not the JVM. Should I try to add a test that verifies that explicitly passing `mvnd.maxHeapSize` is respected and that explicitly passing `-Xmx` works (instead of getting overwritten by `mvnd.maxHeapSize`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
