[
https://issues.apache.org/jira/browse/MWRAPPER-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482101#comment-17482101
]
ASF GitHub Bot commented on MWRAPPER-53:
----------------------------------------
nhojpatrick commented on a change in pull request #16:
URL: https://github.com/apache/maven-wrapper/pull/16#discussion_r792105727
##########
File path: maven-wrapper-distribution/src/resources/mvnw
##########
@@ -259,20 +259,22 @@ else
if [ "$MVNW_VERBOSE" = true ]; then
echo "Falling back to using Java to download"
fi
- javaClass="$BASE_DIR/.mvn/wrapper/MavenWrapperDownloader.java"
+ javaSource="$BASE_DIR/.mvn/wrapper/MavenWrapperDownloader.java"
+ javaClass="$BASE_DIR/.mvn/wrapper/MavenWrapperDownloader.class"
# For Cygwin, switch paths to Windows format before running javac
if $cygwin; then
- javaClass=`cygpath --path --windows "$javaClass"`
+ javaSource=`cygpath --path --windows "javaSource"`
+ javaClass=`cygpath --path --windows "javaClass"`
fi
- if [ -e "$javaClass" ]; then
- if [ ! -e "$BASE_DIR/.mvn/wrapper/MavenWrapperDownloader.class" ];
then
+ if [ -e "$javaSource" ]; then
+ if [ ! -e "$javaClass" ]; then
if [ "$MVNW_VERBOSE" = true ]; then
echo " - Compiling MavenWrapperDownloader.java ..."
fi
# Compiling the Java class
- ("$JAVA_HOME/bin/javac" "$javaClass")
+ ("$JAVA_HOME/bin/javac" "javaSource")
Review comment:
yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> cygwin path tidy for java and class
> -----------------------------------
>
> Key: MWRAPPER-53
> URL: https://issues.apache.org/jira/browse/MWRAPPER-53
> Project: Maven Wrapper
> Issue Type: Improvement
> Components: Maven Wrapper Scripts
> Affects Versions: 3.1.0
> Reporter: John Patrick
> Priority: Major
>
> MavenWrapperDownloader.java needs path fix for cygwin, also doing path fix
> for MavenWrapperDownloader.class.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
