SebastianKuehn commented on a change in pull request #73: URL: https://github.com/apache/maven-plugin-tools/pull/73#discussion_r822365765
########## File path: maven-plugin-plugin/src/it/mplugin-394_report-encoding/invoker.properties ########## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +invoker.goals = -Dfile.encoding=CP1252 plugin:report Review comment: Hallo @michael-o, this was my reproduction of the problem (on a Windows system which has CP1252 as System-Encoding). My goal was to set the default encoding to CP1252, regardless of the system (Linux, Mac etc.). In hindsight you are right, that this test might not work as expected an non Windows machine (i.e. it never fails because the encoding is always UTF-8). Can you propose another way to safely accomplish a default/system/native encoding not equal to utf8 while running this integration test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
