michael-o commented on a change in pull request #158:
URL: https://github.com/apache/maven-resolver/pull/158#discussion_r825006511
##########
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##########
@@ -253,7 +253,9 @@ public CollectResult collectDependencies(
RepositorySystemSession session, Colle
DefaultVersionFilterContext versionContext = new
DefaultVersionFilterContext( session );
- Args args = new Args( session, trace, pool, context,
versionContext, request );
+ Args args =
+ new Args( session, trace, pool, context, versionContext,
request,
+ new DependencyResolutionSkipper() );
Review comment:
Correc, that's be awesome. Interface and two impls. External names:
`never` and maybe `default`?
##########
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##########
@@ -253,7 +253,9 @@ public CollectResult collectDependencies(
RepositorySystemSession session, Colle
DefaultVersionFilterContext versionContext = new
DefaultVersionFilterContext( session );
- Args args = new Args( session, trace, pool, context,
versionContext, request );
+ Args args =
+ new Args( session, trace, pool, context, versionContext,
request,
+ new DependencyResolutionSkipper() );
Review comment:
Correct, that's be awesome. Interface and two impls. External names:
`never` and maybe `default`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
