[ 
https://issues.apache.org/jira/browse/MNG-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536906#comment-17536906
 ] 

ASF GitHub Bot commented on MNG-7468:
-------------------------------------

slawekjaranowski opened a new pull request, #741:
URL: https://github.com/apache/maven/pull/741

   I see only one place for such checking ...
   
   After `MojoExecution` was created and configured all configuration will only 
contains parameters listed in plugin.xml
    
   Maybe I should do it in another way .. 
   
   
   TODO:
    - better message
    - it test new one or fix existing
    
   ---
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed
          for the change (usually before you start working on it).  Trivial 
changes like typos do not
          require a JIRA issue. Your pull request should address just this 
issue, without
          pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line 
and body.
    - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you 
replace `MNG-XXX`
          and `SUMMARY` with the appropriate JIRA issue. Best practice is to 
use the JIRA issue
          title in the pull request title and in the first line of the commit 
message.
    - [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
          be performed on your pull request automatically.
    - [x] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   




> Unsupported plugins parameters in configuration should be verified
> ------------------------------------------------------------------
>
>                 Key: MNG-7468
>                 URL: https://issues.apache.org/jira/browse/MNG-7468
>             Project: Maven
>          Issue Type: New Feature
>          Components: Plugins and Lifecycle
>            Reporter: Slawomir Jaranowski
>            Assignee: Slawomir Jaranowski
>            Priority: Major
>             Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Currently we can provide any xml tags in plugin configuration even if plugin 
> Mojo doesn't support specific parameters.
> eg we can have:
> {code:xml}
> <plugin>
>     <artifactId>example-maven-plugin</artifactId>
>     <version>1.1.1</version>
>     <configuration>
>         <xxx>zzzz</xxx>
>     </configuration>
> </plugin>
> {code}
> With example configuration Mojo is executed without any warning.
> Simply if parameters is not supported - build should break with some of 
> invalid plugin configuration exception ...



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to