[ 
https://issues.apache.org/jira/browse/MNG-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543104#comment-17543104
 ] 

Michael Osipov edited comment on MNG-7448 at 5/27/22 8:09 PM:
--------------------------------------------------------------

Fixed with 
[3ad4fe5a1a3fe803e1372d9093a8ea27e95fc34c|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=3ad4fe5a1a3fe803e1372d9093a8ea27e95fc34c],
 with 
[5002a0b0b8b15334ebcb90b81ad2c2b6a75c1c74|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=5002a0b0b8b15334ebcb90b81ad2c2b6a75c1c74]
 for {{maven-3.9.x}} branch, with 
[23cc8633983f04f243b15b02fc2e92e2807e009d|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=23cc8633983f04f243b15b02fc2e92e2807e009d]
 for {{maven-3.8.x}} branch


was (Author: michael-o):
Fixed with 
[e8c35ae4ab91270b4403b95468254f0978f1c0ca|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=e8c35ae4ab91270b4403b95468254f0978f1c0ca],
 with 
[5002a0b0b8b15334ebcb90b81ad2c2b6a75c1c74|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=5002a0b0b8b15334ebcb90b81ad2c2b6a75c1c74]
 for {{maven-3.9.x}} branch, with 
[23cc8633983f04f243b15b02fc2e92e2807e009d|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=23cc8633983f04f243b15b02fc2e92e2807e009d]
 for {{maven-3.8.x}} branch

> Don't ignore bin/ otherwise bin/ in apache-maven module cannot be readded
> -------------------------------------------------------------------------
>
>                 Key: MNG-7448
>                 URL: https://issues.apache.org/jira/browse/MNG-7448
>             Project: Maven
>          Issue Type: Bug
>    Affects Versions: 3.8.5
>            Reporter: Daqian Liao
>            Assignee: Karl Heinz Marbaise
>            Priority: Minor
>             Fix For: 3.8.6, 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>         Attachments: bin.png, image-2022-05-06-20-32-09-746.png
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> when we download sourcecode, and push code to github, the 
> apache-maven/src/bin directory will not be pushed.
> If we delete bin directory in apache-maven/src, we can not find because git 
> has ignore it .
> The reason is that .gitignore file contains bin at line 6。
> fix: delete bin/ from .gitignore
> !bin.png!
>  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to