michael-o commented on code in PR #38:
URL: https://github.com/apache/maven-filtering/pull/38#discussion_r894619541
##########
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##########
@@ -90,23 +87,25 @@ public boolean filteredFileExtension( String fileName,
List<String> userNonFilte
{
nonFilteredFileExtensions.addAll( userNonFilteredFileExtensions );
}
- String extension = StringUtils.lowerCase( FilenameUtils.getExtension(
fileName ) );
+ String extension = getExtension( fileName );
boolean filteredFileExtension = !nonFilteredFileExtensions.contains(
extension );
- if ( getLogger().isDebugEnabled() )
+ if ( LOGGER.isDebugEnabled() )
{
- getLogger().debug( "file " + fileName + " has a" + (
filteredFileExtension ? " " : " non " )
+ LOGGER.debug( "file " + fileName + " has a" + (
filteredFileExtension ? " " : " non " )
+ "filtered file extension" );
}
return filteredFileExtension;
}
+ private static String getExtension( String fileName )
+ {
+ String rawExt = FilenameUtils.getExtension( fileName );
+ return rawExt == null ? null : rawExt.toLowerCase( Locale.ROOT );
+ }
+
@Override
public List<String> getDefaultNonFilteredFileExtensions()
{
- if ( this.defaultNonFilteredFileExtensions == null )
- {
- this.defaultNonFilteredFileExtensions = new ArrayList<>();
- }
return this.defaultNonFilteredFileExtensions;
Review Comment:
Dammit, not noticed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
