[GitHub] [maven-install-plugin] cstamas commented on a diff in pull request #31: Drop MAT

[GitBox]

cstamas commented on code in PR #31:
URL: 
https://github.com/apache/maven-install-plugin/pull/31#discussion_r901645127


##########
pom.xml:
##########
@@ -100,13 +100,13 @@
       <groupId>org.eclipse.aether</groupId>
       <artifactId>aether-api</artifactId>
       <version>${aetherVersion}</version>
-      <scope>compile</scope>
+      <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>org.eclipse.aether</groupId>
       <artifactId>aether-util</artifactId>
       <version>${aetherVersion}</version>
-      <scope>compile</scope>
+      <scope>compile</scope> <!-- To work in Maven versions older than 3.9.0 
-->

Review Comment:
   Maven 3.2.5 core extensions:
   
https://github.com/apache/maven/blob/2226900a49396ae834b749ff22c126aed89dbf5a/maven-core/src/main/resources/META-INF/maven/extension.xml#L152-L154
   
   Does NOT enlist util, hence, if scope set to provided, it will result in 
CNFEx



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org