[ 
https://issues.apache.org/jira/browse/MNG-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558906#comment-17558906
 ] 

Herve Boutemy commented on MNG-7468:
------------------------------------

thanks [~sjaranowski]: I overlooked the second step checking parameter of other 
goals of the plugin, and didn't have a look at ITs that perfectly check 
everything

the warning message makes me feel uncomfortable:
{noformat}[WARNING] Parameter 'invalidXml' is unknown for plugin 
'maven-it-plugin-configuration:2.1-SNAPSHOT:touch (default)'{noformat}

it says parameter is invalid for plugin xxx, but xxx does not describe a plugin 
but an execution of a goal

what do you think about 
{noformat}[WARNING] Parameter 'invalidXml' is unknown for plugin 
'maven-it-plugin-configuration:2.1-SNAPSHOT' when configuring 'touch 
(default)'{noformat}
?

or even just 
{noformat}[WARNING] Parameter 'invalidXml' is unknown for plugin 
'maven-it-plugin-configuration:2.1-SNAPSHOT'{noformat}
?

and what if there are multiple executions? Is the warning displayed multiple 
times?

> Unsupported plugins parameters in configuration should be verified
> ------------------------------------------------------------------
>
>                 Key: MNG-7468
>                 URL: https://issues.apache.org/jira/browse/MNG-7468
>             Project: Maven
>          Issue Type: New Feature
>          Components: Plugins and Lifecycle
>            Reporter: Slawomir Jaranowski
>            Assignee: Slawomir Jaranowski
>            Priority: Major
>             Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Currently we can provide any xml tags in plugin configuration even if plugin 
> Mojo doesn't support specific parameters.
> eg we can have:
> {code:xml}
> <plugin>
>     <artifactId>example-maven-plugin</artifactId>
>     <version>1.1.1</version>
>     <configuration>
>         <xxx>zzzz</xxx>
>     </configuration>
> </plugin>
> {code}
> With example configuration Mojo is executed without any warning.
> Simply if parameters is not supported - build should break with some of 
> invalid plugin configuration exception ...



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to