[
https://issues.apache.org/jira/browse/SCM-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568936#comment-17568936
]
ASF GitHub Bot commented on SCM-807:
------------------------------------
kwin commented on code in PR #152:
URL: https://github.com/apache/maven-scm/pull/152#discussion_r925338741
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/JGitUtils.java:
##########
@@ -308,7 +336,7 @@ public static List<ScmFile> addAllFiles( Git git,
ScmFileSet fileSet )
if ( file.exists() )
{
- String path = relativize( baseUri, file );
Review Comment:
No, all JGit commands take relative repo paths with forward slashes
(independent of OS/FS)
(https://archive.eclipse.org/jgit/site/4.6.0.201612231935-r/apidocs/org/eclipse/jgit/api/AddCommand.html#addFilepattern-java.lang.String-)
> JGit impl check-in fails unless the Maven project is in the working copy root
> -----------------------------------------------------------------------------
>
> Key: SCM-807
> URL: https://issues.apache.org/jira/browse/SCM-807
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
> Affects Versions: 1.9.4
> Reporter: Richard DiCroce
> Priority: Major
> Attachments: scm-807.txt
>
>
> Another problem exposed by maven-release-plugin: the JGit SCM
> implementation's check-in fails unless the Maven project is in the working
> copy root because it confuses the working copy's location with the Maven
> project's location.
> The attached patch resolves the issue. Combined with the patch attached to
> SCM-806, release:prepare now mostly succeeds with the JGit implementation.
> There is still a problem with the POM not being transformed correctly, but
> that's a problem in maven-release-plugin.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
