olamy commented on code in PR #47:
URL: https://github.com/apache/maven-jar-plugin/pull/47#discussion_r943016081
##########
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##########
@@ -196,16 +196,17 @@ protected File getJarFile( File basedir, String
resultFinalName, String classifi
throw new IllegalArgumentException( "finalName is not allowed to
be null" );
}
- StringBuilder fileName = new StringBuilder( resultFinalName );
-
+ final String fileName;
Review Comment:
all good. please remove those `final` as I don't think they make sense for a
local variable. except adding more useless code.
btw I'm more a sugar free person if it's not really needed 🤣
if you want to create a jira why not but I'm not sure we need a Jira for
such code polishing.
it's up2u
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
