[
https://issues.apache.org/jira/browse/MNG-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616334#comment-17616334
]
ASF GitHub Bot commented on MNG-7561:
-------------------------------------
kwin commented on code in PR #823:
URL: https://github.com/apache/maven/pull/823#discussion_r993263931
##########
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java:
##########
@@ -111,28 +111,36 @@ public VersionRangeResult resolveVersionRange(
RepositorySystemSession session,
}
else
{
- Map<String, ArtifactRepository> versionIndex = getVersions(
session, result, request );
-
- List<Version> versions = new ArrayList<>();
- for ( Map.Entry<String, ArtifactRepository> v :
versionIndex.entrySet() )
+ if ( Objects.equals( versionConstraint.getRange().getLowerBound(),
+ versionConstraint.getRange().getUpperBound()
) )
+ {
+ result.addVersion(
versionConstraint.getRange().getLowerBound().getVersion() );
Review Comment:
why is this shortcut allowed for recommended versions (soft-references)?
> DefaultVersionRangeResolver should not try to resolve request with same upper
> and lower bound
> ---------------------------------------------------------------------------------------------
>
> Key: MNG-7561
> URL: https://issues.apache.org/jira/browse/MNG-7561
> Project: Maven
> Issue Type: Improvement
> Components: Artifacts and Repositories
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> For dependencies having e.g. version {{[1.0]}} the
> DefaultVersionRangeResolver still tries to resolve versions although only a
> single version (namely 1.0) is valid here according to
> https://maven.apache.org/pom.html#Dependency_Version_Requirement_Specification.
>
> This leads in the worst case to long-running calls against a remote
> repository for no reason.
> There should be a shortcut in
> https://github.com/apache/maven/blob/3f90e7028e0338c110aea267b44362653d55273a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java#L108
> when the range has the same upper and lower bound.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
