gnodet commented on PR #147: URL: https://github.com/apache/maven-plugin-tools/pull/147#issuecomment-1276741523
> > I would like to have a report in maven-plugin-plugin module which simply extends reports from new module. We can override `executeReport` methods with warning and call supper. > > In such way we need not to duplicate code. What do you thing? > > We should have a separate java package in separate module. > > I suppose it would be a bit cleaner. What I had in mind was to switch to 4.0-SNAPSHOT soon after the 3.7 release. So not sure it's really worth the extra work, but I'll try it anyway. I was about to try, but I realized there is problem with this approach. I think it makes sense to keep the ITs with the report. However, the ITs actually need the `maven-plugin-plugin` to generate the plugins and then run the `site` goal. This means a cyclic dependency, which would have to be broken by moving back the ITs to the `maven-plugin-plugin` or to a new module... so not really sure the end state would be really better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
