ppalaga commented on code in PR #721:
URL: https://github.com/apache/maven-mvnd/pull/721#discussion_r998644823
##########
client/src/main/java/org/mvndaemon/mvnd/client/DaemonParameters.java:
##########
@@ -150,8 +150,11 @@ public Path javaHome() {
}
}
- private String javaHomeFromPath() {
- final String jHome = OsUtils.findJavaHomeFromPath();
+ private static String javaHomeFromPath() {
+ LOG.warn("Falling back to finding JAVA_HOME by running java executable
available in PATH."
Review Comment:
> why warn here? the generic java version (mvnd.sh) will also search java
from path without a warning
As long as I am on an OS and arch having a mvnd native executable, I do not
need to care that mvnd.sh is slow. mvnd.sh is fallback where some expectations
are not met. But actually we could warn in mvnd.sh too. I'd prefer knowing that
mvnd is missing some piece of config that makes it slower.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
