cstamas commented on code in PR #203:
URL: https://github.com/apache/maven-resolver/pull/203#discussion_r1004082829
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/checksum/FileTrustedChecksumsSourceSupport.java:
##########
@@ -151,29 +138,40 @@ protected String configPropKey( String name )
}
/**
- * Returns {@code true} if session configuration contains "originAware"
property set to {@code true}.
+ * Returns {@code true} if session configuration marks this instance as
enabled.
+ * <p>
+ * Default value is {@code false}.
+ */
+ protected boolean isEnabled( RepositorySystemSession session )
+ {
+ return ConfigUtils.getBoolean( session, false, CONFIG_PROP_PREFIX +
this.name );
+ }
+
+ /**
+ * Returns {@code true} if session configuration marks this instance as
origin aware.
+ * <p>
+ * Default value is {@code true}.
*/
protected boolean isOriginAware( RepositorySystemSession session )
{
- return ConfigUtils.getBoolean( session, false, configPropKey(
CONF_NAME_ORIGIN_AWARE ) );
+ return ConfigUtils.getBoolean( session, true, configPropKey(
CONF_NAME_ORIGIN_AWARE ) );
Review Comment:
This has nothing to do with LRM and are they split or not. This way you just
say "junit 4.13.2 from central has sha-1
8ac9e16d933b6fb43bc7f576336b8f4d7eb5ba12" and turn on "fail if missing" and you
are done. Or in other words, this makes possible to maintain lists of checksums
"by origin" that is IMHO simper than "in bulk", where list would be project
specific, while this way, those lists are reusable across projects.
Again, this is just a default, and while I do see valid points for both
(per-origin and in-bulk), it can be easily overriden,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
