[
https://issues.apache.org/jira/browse/MRESOLVER-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629163#comment-17629163
]
ASF GitHub Bot commented on MRESOLVER-286:
------------------------------------------
michael-o commented on code in PR #215:
URL: https://github.com/apache/maven-resolver/pull/215#discussion_r1014360127
##########
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##########
@@ -297,10 +303,7 @@ public void get( Collection<? extends ArtifactDownload>
artifactDownloads,
public void put( Collection<? extends ArtifactUpload> artifactUploads,
Collection<? extends MetadataUpload> metadataUploads )
{
- if ( closed )
- {
- throw new IllegalStateException( "connector closed" );
- }
+ failIfClosed();
Review Comment:
`Connector already closed`?
> Improve basic connector closed state handling
> ---------------------------------------------
>
> Key: MRESOLVER-286
> URL: https://issues.apache.org/jira/browse/MRESOLVER-286
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 1.9.0
>
>
> Basic connector was last that handled closed state in a bit "wonky" way,
> rework to use it AtomicBoolean as everything else in resolver.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
