mbien commented on code in PR #277: URL: https://github.com/apache/maven-indexer/pull/277#discussion_r1032837233
########## indexer-core/src/main/java/org/apache/maven/index/updater/IndexDataReader.java: ########## @@ -165,8 +165,8 @@ private IndexDataReadResult readIndexMT( IndexWriter w, IndexingContext context final Document theEnd = new Document(); - ConcurrentMap<String, Boolean> rootGroups = new ConcurrentHashMap<>(); - ConcurrentMap<String, Boolean> allGroups = new ConcurrentHashMap<>(); + Set<String> rootGroups = ConcurrentHashMap.newKeySet(); + Set<String> allGroups = ConcurrentHashMap.newKeySet(); Review Comment: I tried to size them appropriately (central has about 70k groups, and resizing CHMs has a larger impact than normal maps), but since this made no performance difference I left the defaults as is. (tested only twice so the sample size is small though, noise is a bit high) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org