[ 
https://issues.apache.org/jira/browse/MNG-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642854#comment-17642854
 ] 

ASF GitHub Bot commented on MNG-7615:
-------------------------------------

cstamas commented on code in PR #893:
URL: https://github.com/apache/maven/pull/893#discussion_r1038801109


##########
maven-model-builder/src/main/java/org/apache/maven/model/superpom/DefaultSuperPomProvider.java:
##########
@@ -52,8 +53,8 @@ public DefaultSuperPomProvider(ModelProcessor modelProcessor) 
{
 
     @Override
     public Model getSuperModel(String version) {
-        if (superModel == null) {
-            String resource = "/org/apache/maven/model/pom-" + version + 
".xml";
+        return SUPER_MODELS.computeIfAbsent(version, v -> {

Review Comment:
   Does this mean that for example maven 4.0.1 could return super POM of Maven 
3.8.6 (ie. newer could have all super POMs of older Mavens?)





> Multithreaded model builder
> ---------------------------
>
>                 Key: MNG-7615
>                 URL: https://issues.apache.org/jira/browse/MNG-7615
>             Project: Maven
>          Issue Type: Task
>            Reporter: Guillaume Nodet
>            Assignee: Guillaume Nodet
>            Priority: Major
>
> Parsing all reactor models can be very lengthy, so use a map/reduce algorithm 
> to make the computation in parallel.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to