[
https://issues.apache.org/jira/browse/MRESOLVER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645939#comment-17645939
]
ASF GitHub Bot commented on MRESOLVER-307:
------------------------------------------
cstamas commented on PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1345989051
In short: japicmp fails with a reason, this is a breakage.
Longer story: We have a page
https://maven.apache.org/resolver/api-compatibility.html that explains how we
"expect" clients to behave, and what we promise. In this case, this PR breaks
our promise. This is why common (but not applied to all) approach is visible on
this example:
Listener interface
https://github.com/apache/maven-resolver/blob/ce54f7f371eaf37657413d7b7135171aa88cba40/maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferListener.java
FORBIDS direct implementation, instead, it directs you to
https://github.com/apache/maven-resolver/blob/ce54f7f371eaf37657413d7b7135171aa88cba40/maven-resolver-api/src/main/java/org/eclipse/aether/transfer/AbstractTransferListener.java
support class. Now, we cannot "enforce" this in any way (so "bad" clients
still can directly implement interface), but according to that page, then they
are "on their own". The presence of support class in chain `iface -> support
class -> impl` allows us to introduce methods that would be otherwise breaking.
Problem is, WorkspaceReader is NOT introduced in that set (see japicmp
config). We may change that of course....
> Support listing of workspace artifacts
> --------------------------------------
>
> Key: MRESOLVER-307
> URL: https://issues.apache.org/jira/browse/MRESOLVER-307
> Project: Maven Resolver
> Issue Type: Improvement
> Reporter: Christoph Läubrich
> Priority: Major
>
> Currently the WorkspaceReader has a way to list versions or resolve the file
> for an artifact, but there is no way of really get a list of workspace
> artifacts itself.
> The javadoc states:
> {quote}Manages a repository backed by the IDE workspace, a build session or a
> similar ad-hoc collection of artifacts.{quote}
> so the goal is to have a way getting hold of the "collection of artifacts"
> this Workspacereader manages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
