[
https://issues.apache.org/jira/browse/MWRAPPER-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648225#comment-17648225
]
ASF GitHub Bot commented on MWRAPPER-77:
----------------------------------------
bmarwell opened a new pull request, #73:
URL: https://github.com/apache/maven-wrapper/pull/73
TODO test: Install the latest snapshot and try to update itself (see Hervé's
comment in the JIRA issue).
----
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MWRAPPER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MWRAPPER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> wrapper:wrapper does not update scripts
> ---------------------------------------
>
> Key: MWRAPPER-77
> URL: https://issues.apache.org/jira/browse/MWRAPPER-77
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Plugin
> Affects Versions: 3.1.1
> Reporter: Tamas Cservenak
> Priority: Major
>
> On my ancient project seems that scripts (mvnw and mvnw.cmd) were not updated
> after I ran {{wrapper:wrapper}} while the rest was okay.
> To test my assumption, moved them to mvnw.old and mvnw.cmd.old and re-run
> {{{}wrapper:wrapper{}}}. This time the scripts were written out just fine.
> But, they were totally different. This also means that scrpts, once written
> out, will never we updated?
> End result I had:
> {noformat}
> -rwxr-xr-x. 1 cstamas cstamas 9781 máj 8 09.15 mvnw
> -rw-r--r--. 1 cstamas cstamas 6889 máj 8 09.15 mvnw.cmd
> -rw-r--r--. 1 cstamas cstamas 6607 szept 1 15.55 mvnw.cmd.old
> -rwxr-xr-x. 1 cstamas cstamas 10069 szept 1 15.55 mvnw.old {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
