bmarwell commented on code in PR #61: URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1062387739
########## maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java: ########## @@ -31,23 +31,23 @@ import java.util.Map; import java.util.Properties; -import org.junit.Before; -import org.junit.Test; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; -public class SystemPropertiesHandlerTest +class SystemPropertiesHandlerTest Review Comment: Actually, not so great. You will need to redo most of it b/c parent v39 requires a new style (which will cause a LOT of git merge conflicts): https://github.com/apache/maven-wrapper/pull/81 Maybe you just want to update here to v38 first before I do the v39 update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
