psiroky commented on code in PR #170:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/170#discussion_r1086070565


##########
pom.xml:
##########
@@ -249,13 +249,8 @@ under the License.
                       ! https://issues.apache.org/jira/browse/MINVOKER-174
                       -->
                     <setupIncludes>
-                      <setupInclude>setup_jar_module/pom.xml</setupInclude>
-                      <setupInclude>setup_jar_automodule/pom.xml</setupInclude>
-                      <setupInclude>setup_x/pom.xml</setupInclude>
+                      <setupInclude>setup*/pom.xml</setupInclude>

Review Comment:
   This makes sure that any new `setup` projects following the naming 
convention will be automatically picked up. If there is any potential concern 
with this approach, I can revert to the explicit list.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to