s-rwe opened a new pull request, #615: URL: https://github.com/apache/maven-surefire/pull/615
Suggestion to support SUREFIRE-2152, helping developers identify problematic invocations of templated tests much quicker, especially also based on the console output. The initial commit a87457bb to handle JUnit5 templated tests quite separately in `RunListenerAdapter` also fixes another issue mentioned recently on SUREFIRE-2087, namely this one: * https://issues.apache.org/jira/browse/SUREFIRE-2087?focusedCommentId=17690951#comment-17690951 I could assume that especially ff694485 might be controversial in this, since it mixes up the separation between the `methodDesc` and `methodDisp` (introduced in SUREFIRE-1546, AFAICS) to some extent. However, I would argue that it's quite important to be able to see the display-name of templated tests in general (i.e., in particular also in the default output of the console reporter), else it can be tedious to figure out more details. Still, it might be useful to make the changes of ff694485 conditional of a configuration flag - i.e. keeping it disabled by default and have a flag for opt-in (I don't really know how a config-flag would need to be done, help welcome if you'd consider that useful too) Validation: - [x] `mvn clean install` is successful - [ ] `mvn -Prun-its clean install` - This fails on me unfortunately with error below (doesn't seem related to my changes, maybe linked #543?): ``` Failed to install project dependencies: MavenProject: org.apache.maven.plugins:maven-failsafe-plugin:3.0.0-M10-SNAPSHOT [...] cannot install /home/me/.m2/repository/org/apache/maven/maven-parent/36/maven-parent-36.pom to same path ``` - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
