[ https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695800#comment-17695800 ]
Elliotte Rusty Harold commented on MNG-6825: -------------------------------------------- Feel free to throw any reviews my way. I do prefer smaller reviews. They tend not to be drop in replacements since null checking particular can vary from one line of code to the next. E.g. sometimes a StringUtils.isEmpty replacement needs to include a null check and sometime it doesn't if the string has already been dereferenced previously. We don't really have tooling to perform a lot of these modifications at scale, so if you do what you can when you can, eventually we'll get it done. https://google.github.io/eng-practices/review/developer/small-cls.html > Cleaning Up dependencies > plexus-utils/maven-shared-utils/commons-lang3/commons-io > --------------------------------------------------------------------------------- > > Key: MNG-6825 > URL: https://issues.apache.org/jira/browse/MNG-6825 > Project: Maven > Issue Type: Improvement > Components: Bootstrap & Build > Affects Versions: 3.6.3 > Reporter: Karl Heinz Marbaise > Assignee: Karl Heinz Marbaise > Priority: Minor > Fix For: 4.0.x-candidate > > > Experiment to see if we can get rid of commons-lang3 dependency. > * Identified code duplication between: > ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879 > Bytes commons-lang3-3.8.1.jar) > ** {{org.codehaus.plexus.util.StringUtil}} from {{plexus-utils}} (261801 > Bytes plexus-utils-3.2.1.jar) > ** {{org.apache.maven.shared.utils}} from {{maven-shared-utils}} (166562 > Bytes maven-shared-utils-3.2.1.jar) > ** We should replace the self implemented with > {{org.codehaus.plexus.util.StringUtil}}. or with {{maven-shared-utils}} > * {{commons-io}} usage by {{maven-shared-utils}} (208700 Bytes > commons-io-2.5.jar) -- This message was sent by Atlassian Jira (v8.20.10#820010)