gnodet commented on code in PR #1061:
URL: https://github.com/apache/maven/pull/1061#discussion_r1142090120
##########
maven-model-builder/src/site/apt/index.apt:
##########
@@ -192,6 +192,10 @@ Maven Model Builder
*----+------+------+
| <<<maven.home>>> | The path to the current Maven home. |
<<<$\{maven.home\}>>> |
*----+------+------+
+| <<<maven.rootdir>>> | the directory containing the root <<<pom.xml>>> file
of a multi module project, in a single module project this is the same as
<<<project.basedir>>> | <<<$\{maven.rootdir\}>>> |
+*----+------+------+
+| <<<maven.topdir>>> | the directory containing the top-level <<<pom.xml>>> in
this reactor build | <<<$\{maven.topdir\}>>> |
+*----+------+------+
Review Comment:
I agree, I'll remove all references to `maven.rootdir` and `maven.topdir`.
It makes sense to keep `session.rootdir` and `session.topdir` because they are
available from those objects.
I'd rather [set them as `session.rootdir` and `session.topdir` in the
request system
properties](https://github.com/apache/maven/pull/1061/files#diff-b8b814f5b6b3855ae79dc45a0266b94871193dcef42803c316e07409e94af35cR612-R617).
That would allow using them in the context of [arguments interpolation /
`MNG-6303`](https://github.com/apache/maven/pull/1062).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
