[ 
https://issues.apache.org/jira/browse/MJAVADOC-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703133#comment-17703133
 ] 

Geoffrey De Smet commented on MJAVADOC-747:
-------------------------------------------

The stacktrace seems to indicate this is a user's problem - after all, there is 
an "Automatic Module Name" defined on the project and one of its dependencies 
is not module friendly (it uses the no-name package), so the javadoc plugin 
rightly fails. Right?

However, I'd argue it's not a user's problem:

- Using "Automatic Module Name" is a way for open source projects that don't 
want to go through the JPMS hassle today, to prepare themselves if they do want 
to go through it some day - with minimal impact to their JPMS users.
- This issue effectively blocks the use of "Automatic Module Name" if quarkus, 
openrewrite or other dependencies that don't care about JPMS are in the 
dependencies.
- The compiler plugin etc all don't fail on this, only the new javadoc plugin 
version (3.3.0+) does (=> regression).

> jar goal fails with automatic module  (Regression from 3.2.0)
> -------------------------------------------------------------
>
>                 Key: MJAVADOC-747
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-747
>             Project: Maven Javadoc Plugin
>          Issue Type: Bug
>          Components: jar
>    Affects Versions: 3.3.0, 3.3.1, 3.3.2, 3.4.0, 3.4.1, 3.5.0
>            Reporter: Geoffrey De Smet
>            Priority: Blocker
>
> In optaplanner, we provide automatic module names for all our modules.
> But some modules have a dependency with classes in the no-name package.
> That was not a problem for the maven-javadoc-plugin, except since 
> maven-javadoc-plugin 3.3.0 (including 3.5.0) it crashes the entire build.
> This happens with dependencies on quarkus and on rewrite.
> For example, for optaplanner-migrator that depends on rewrite-maven and 
> rewrite-gradle:
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.5.0:jar (default) on project 
> reproducer:
> Execution default of goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.5.0:jar failed:
> Unable to derive module descriptor for 
> /.../.m2/repository/org/openrewrite/rewrite-gradle/7.38.0/rewrite-gradle-7.38.0.jar:
> PluginSpec.class found in top-level directory (unnamed package not allowed in 
> module) -> [Help 1]{code}
> Isolated reproducer:
>   [https://github.com/ge0ffrey/maven-javadoc-plugin-3.5.0-reproducer]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to