[ 
https://issues.apache.org/jira/browse/MNG-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703646#comment-17703646
 ] 

ASF GitHub Bot commented on MNG-7738:
-------------------------------------

elharo commented on code in PR #1064:
URL: https://github.com/apache/maven/pull/1064#discussion_r1144744437


##########
maven-core/src/test/java/org/apache/maven/repository/TestRepositorySystem.java:
##########
@@ -229,7 +229,7 @@ public ArtifactResolutionResult 
resolve(ArtifactResolutionRequest request) {
                             .map(Dependency::new)
                             .collect(Collectors.toList());
                 } catch (IOException e) {
-                    e.printStackTrace();

Review Comment:
   On further investigation, this immensely over-engineered class is used in 
exactly one test method `testCacheKey` which doesn't even enter this method 
when it runs. 





> Remove printStackTrace
> ----------------------
>
>                 Key: MNG-7738
>                 URL: https://issues.apache.org/jira/browse/MNG-7738
>             Project: Maven
>          Issue Type: Bug
>            Reporter: Elliotte Rusty Harold
>            Assignee: Elliotte Rusty Harold
>            Priority: Minor
>
> There are multiple places in core where the code simply calls 
> ex.printStackTrace() or equivalent, usually in a catch block, instead of 
> going through the logging framework. This produces ugly, uncontrollable, 
> often duplicate output. Remove or replace these. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to