slawekjaranowski commented on code in PR #134: URL: https://github.com/apache/maven-assembly-plugin/pull/134#discussion_r1174596627
########## src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java: ########## @@ -351,6 +349,23 @@ protected Archiver createArchiver( return archiver; } + private void configureJarArchiver( + JarArchiver archiver, String mergeManifestMode, MavenArchiveConfiguration configuration) { + + if (mergeManifestMode != null) { + archiver.setFilesetmanifest(JarArchiver.FilesetManifestConfig.valueOf(mergeManifestMode)); + } + + archiver.setMinimalDefaultManifest(true); Review Comment: yes - exactly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org