[
https://issues.apache.org/jira/browse/MNG-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721354#comment-17721354
]
ASF GitHub Bot commented on MNG-6829:
-------------------------------------
timtebeek commented on code in PR #90:
URL: https://github.com/apache/maven-wagon/pull/90#discussion_r1189909018
##########
wagon-provider-test/src/main/java/org/apache/maven/wagon/http/HttpWagonTestCase.java:
##########
@@ -936,7 +936,7 @@ protected void checkHandlerResult(
List<HandlerRequestResponse> handlerRequestRe
{
for ( int i = 0; i < expectedResponseCodes.length; i++ )
{
- success &= ( expectedResponseCodes[i] ==
handlerRequestResponses.get( i ).responseCode );
+ success &= expectedResponseCodes[i] ==
handlerRequestResponses.get( i ).responseCode;
Review Comment:
As an implementation detail, the recipe to remove StringUtils isEmpty
originally insta the statement wrapped in parentheses. Then, only when
possible, it [removes unnecessary
parentheses](https://github.com/openrewrite/rewrite-migrate-java/blob/main/src/main/java/org/openrewrite/java/migrate/apache/commons/lang/IsNotEmptyToJdk.java#L94).
In rare cases that might clean up unrelated parentheses. Should be rare, but I
thought it to be mostly harmless. Let me know if you'd like me to prevent such
changes.
> Remove commons-lang3 dependency
> -------------------------------
>
> Key: MNG-6829
> URL: https://issues.apache.org/jira/browse/MNG-6829
> Project: Maven
> Issue Type: Sub-task
> Components: Bootstrap & Build
> Affects Versions: 3.6.3
> Reporter: Karl Heinz Marbaise
> Assignee: Karl Heinz Marbaise
> Priority: Minor
> Labels: close-pending
> Fix For: 4.0.x-candidate
>
> Attachments: dtPKn.xlsx
>
>
> Currently we use {{commons-lang3}} for the following classes
> * {{StringUtils}} can be replaced by usage of either {{plexus-utils}} or
> {{maven-shared-utils}} or as I tested with self implementation
> * {{SystemUtils}} is only used in some tests which can simply replaced by
> using JUnit Jupiter with all the support it has.
> * {{Validate}} is a precondition class which checks for parameters etc. can
> be implemented very easily (done already to see how it works). Later this
> could be made part of {{maven-shared-utils}}.
> * Currently the {{StringUtils.substringAfterLast( resourceName, "/" )}} is
> used in {{ConsoleMavenTransferListener}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
