belingueres commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191582040
##########
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##########
@@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() {
endSection();
}
+ private String getHighestVersion(double version) {
+ if (version >= 1.0d) {
Review Comment:
I think that was a bug. If all dependencies have jarDetails.getJdkRevision()
== null, then the summary column would print "0.0" instead of "-". The same
goes for test scope dependencies (it might be the case that there are no test
scoped dependencies at all). Perhaps this is clearer: "if (version > 0.0d) ...."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
