[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721877#comment-17721877 ]
ASF GitHub Bot commented on MPIR-431: ------------------------------------- belingueres commented on code in PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191582040 ########## src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java: ########## @@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() { endSection(); } + private String getHighestVersion(double version) { + if (version >= 1.0d) { Review Comment: I think that was a bug. If all dependencies have jarDetails.getJdkRevision() == null, then the summary column would print "0.0" instead of "-". The same goes for test scope dependencies (it might be the case that there are no test scoped dependencies at all). Perhaps this is clearer: "if (version > 0.0d) ...." > Dependency file details section: segregate Java version column into execution > and test versions > ----------------------------------------------------------------------------------------------- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies > Reporter: Gabriel Belingueres > Assignee: Michael Osipov > Priority: Minor > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)