elharo commented on code in PR #33:
URL: https://github.com/apache/maven-archiver/pull/33#discussion_r1209439247


##########
src/main/java/org/apache/maven/archiver/MavenArchiveConfiguration.java:
##########
@@ -35,6 +35,10 @@ public class MavenArchiveConfiguration {
 
     private boolean recompressAddedZips = true;
 
+    /**
+     * @deprecated See <a 
href="https://bugs.openjdk.org/browse/JDK-8305597";>JDK-8305597</a>
+     */
+    @Deprecated

Review Comment:
   Deprecating the method is enough. Private fields can be changed freely 
without worrying about compatibility when they're no longer used. Adding 
Javadoc to private fields, deprecation warnings included, is painting the lily. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to