ctubbsii commented on code in PR #155:
URL:
https://github.com/apache/maven-apache-parent/pull/155#discussion_r1214516616
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and
surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for
m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+
<mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+
<mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
> I respect your opinion, as you look at linked issues such convention is
already used in many Maven projects
>
> I also was trying to find what kind of properties are used in other ASF
project ... I have found, eg: `<artifactId>.version` `<artifactId>-version`
`<artifactId with dot instead of dash>.version`
>
> I didn't found properties with versions word as prefix.
I haven't found many that do this either... but in my experience, it's a
much better convention to put version at the front, especially when using
plugins like sortpom-maven-plugin to organize the POM and sort the properties.
It's very convenient to have all the versions grouped together. Many projects
don't know about sortpom-maven-plugin, and don't use it, though, despite it
being a superb plugin for POM quality control.
>
> I afraid that there is no convention which can be ok for all, how many
projects, so many opinions
Agreed. But my hope is that the reasons I provided are worth serious
consideration, and more people will adopt similar conventions on the same
grounds, in the absence of arguments against. Specifically: sort-ability and
search-ability are the reasons I gave (I think both help with maintainability:
smaller diffs, easier to find and update things).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
