[jira] [Commented] (MNG-5789) README.txt in distro doesn't say Maven 3.3.1 requires JDK 1.7

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/MNG-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730534#comment-17730534
 ] 

ASF GitHub Bot commented on MNG-5789:
-------------------------------------

rmannibucau commented on code in PR #1145:
URL: https://github.com/apache/maven/pull/1145#discussion_r1222965368


##########
maven-plugin-api/src/main/mdo/plugin.mdo:
##########
@@ -24,9 +24,10 @@ under the License.
   <description><![CDATA[
     Plugin descriptor, stored in <code>META-INF/maven/plugin.xml</code> in a 
plugin's jar artifact.
     This descriptor is generally generated from plugin sources, using
-    <a href="/plugins/maven-plugin-plugin/">maven-plugin-plugin</a>.
-    <p><i>Notice:</i> this documentation is generated from a Modello model but 
the code executed is not generated
-    from this descriptor. Please report if you find anything wrong.</p>
+    <a href="/plugins/maven-plugin-plugin/">maven-plugin-plugin</a>, but other 
tools may geenrated it or it could even be hand-written.

Review Comment:
   The two cases I met and think are ok were:
   
   1. Don't depend on the maven build stack for a simple plugin (= very few 
primitives as param) - this one was "old"
   2. No maven in the build pipeline (saw plain makefile like to build "build 
tools" and some sbt case)
   
   That said no issue to drop the extra part, just wanted to highlight we might 
not want to enforce the usage of a maven plugin and keep it as a contract since 
it is what it is by design.





> README.txt in distro doesn't say Maven 3.3.1 requires JDK 1.7
> -------------------------------------------------------------
>
>                 Key: MNG-5789
>                 URL: https://issues.apache.org/jira/browse/MNG-5789
>             Project: Maven
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 3.3.1
>         Environment: n/a
>            Reporter: Anders Hammar
>            Assignee: Jason van Zyl
>            Priority: Major
>
> README.txt needs to be updated to specify that Maven 3.3+ requires JDK 1.7



--
This message was sent by Atlassian Jira
(v8.20.10#820010)