[
https://issues.apache.org/jira/browse/MSHARED-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733733#comment-17733733
]
Michael Osipov commented on MSHARED-193:
----------------------------------------
[~hboutemy], after touching all of our renders and looking again at this, I
think this should be closed as wontfix and I will explain why:
A renderer (view in MVC) is the last layer, there is no logic, no data
retrieval. Data (model) must be fetched and prepared by the controller, here
the report and passed to the view (renderer) and the view's sole purpose is to
print it out. Done. See
[here|https://github.com/apache/maven-invoker-plugin/commit/a154e5b13dd7d900829d1d951efff50c41f25738]
for a good example.
Let me know what you think!
> No checked exceptions for rendering
> -----------------------------------
>
> Key: MSHARED-193
> URL: https://issues.apache.org/jira/browse/MSHARED-193
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-reporting-api, maven-reporting-impl
> Affects Versions: maven-reporting-impl-2.1, maven-reporting-api-3.0
> Reporter: Benson Margulies
> Priority: Major
> Labels: doxia-2.0.0-stack
>
> It seems unfortunate that
> [org.apache.maven.reporting.MavenReportRenderer.render()|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReportRenderer.html]
> does not throw MavenReportingException. Thus, even though the execute method
> for a report throws that exception, rendering problems cannot.
> Obviously, a change to this would ramify. Would there be any chance of
> acceptance for a patch that added this 'throws'? Alternatively, how about an
> unchecked cousin of MavenReportingException?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
