[ https://issues.apache.org/jira/browse/MDEP-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735606#comment-17735606 ]
ASF GitHub Bot commented on MDEP-875: ------------------------------------- slawekjaranowski commented on code in PR #328: URL: https://github.com/apache/maven-dependency-plugin/pull/328#discussion_r1236603544 ########## src/main/java/org/apache/maven/plugins/dependency/ListRepositoriesMojo.java: ########## @@ -104,8 +104,10 @@ public boolean visitLeave(DependencyNode node) { .collect(Collectors.groupingBy( repo -> repo.getMirroredRepositories().isEmpty())); - prepareRemoteRepositoriesList(message, repoGroupByMirrors.get(Boolean.TRUE)); - prepareRemoteMirrorRepositoriesList(message, repoGroupByMirrors.get(Boolean.FALSE)); + prepareRemoteRepositoriesList( + message, repoGroupByMirrors.getOrDefault(Boolean.TRUE, Collections.emptyList())); + prepareRemoteMirrorRepositoriesList( + message, repoGroupByMirrors.getOrDefault(Boolean.FALSE, Collections.emptyList())); Review Comment: We can also check in methods `prepareRemote*` if list is empty to avoid produce incomplete message. > Regression: list-repositories may produce NPE > --------------------------------------------- > > Key: MDEP-875 > URL: https://issues.apache.org/jira/browse/MDEP-875 > Project: Maven Dependency Plugin > Issue Type: Bug > Components: list-repositories > Affects Versions: 3.6.0 > Reporter: Rostislav Krasny > Assignee: Slawomir Jaranowski > Priority: Major > > Running the *{{mvn > org.apache.maven.plugins:maven-dependency-plugin:3.6.0:list-repositories}}* > command on a projects that has no repository with mirror or only repositories > with mirrors fails with an NPE like in the following example: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-dependency-plugin:3.6.0:list-repositories > (default-cli) on project d > emo: Execution default-cli of goal > org.apache.maven.plugins:maven-dependency-plugin:3.6.0:list-repositories > failed: Cannot invoke > "java.util.Collection.forEach(java.util.function.Consumer)" because > "remoteProjectRepositories" is null -> [Help 1] > The "project demo" is a simple default project made by > https://start.spring.io/ > This regression was introduced by fix of MDEP-853 and exists only in the > {{3.6.0}} version of the plugin. -- This message was sent by Atlassian Jira (v8.20.10#820010)