[
https://issues.apache.org/jira/browse/MNG-7812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736501#comment-17736501
]
ASF GitHub Bot commented on MNG-7812:
-------------------------------------
elharo commented on code in PR #1158:
URL: https://github.com/apache/maven/pull/1158#discussion_r1239857867
##########
maven-embedder/src/main/java/org/apache/maven/cli/jansi/MessageUtils.java:
##########
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.cli.jansi;
+
+import org.apache.maven.api.services.MessageBuilder;
+import org.apache.maven.internal.impl.DefaultMessageBuilder;
+import org.fusesource.jansi.Ansi;
+import org.fusesource.jansi.AnsiConsole;
+import org.fusesource.jansi.AnsiMode;
+
+/**
+ * Colored message utils, to manage colors consistently across plugins (only
if Maven version is at least 3.5.0).
+ * For Maven version before 3.5.0, message built with this util will never add
color.
+ * <p>
+ * Internally, <a href="http://fusesource.github.io/jansi/";>Jansi</a> is used
to render
+ * <a href="https://en.wikipedia.org/wiki/ANSI_escape_code#Colors";>ANSI
colors</a> on any platform.
+ * @since 3.1.0
Review Comment:
This comment should be updated.
##########
maven-embedder/src/main/java/org/apache/maven/cli/jansi/Style.java:
##########
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.cli.jansi;
+
+import java.util.Locale;
+
+import org.fusesource.jansi.Ansi;
+import org.fusesource.jansi.Ansi.Color;
+
+/**
+ * Configurable message styles.
+ * @since 3.1.0
Review Comment:
4.0
> Get rid of maven-shared-utils dependency
> ----------------------------------------
>
> Key: MNG-7812
> URL: https://issues.apache.org/jira/browse/MNG-7812
> Project: Maven
> Issue Type: Dependency upgrade
> Components: Dependencies
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Priority: Major
> Fix For: 4.0.0-alpha-6
>
>
> This issue will seek to remove maven-shared-utils from the list of maven
> dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
