[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736802#comment-17736802
]
Michael Osipov edited comment on DOXIASITETOOLS-253 at 6/24/23 10:05 PM:
-------------------------------------------------------------------------
I am inclined to drop the border attribute altogether since there are so many
aspects you can fiddle with CSS that is basically makes no sense to have one
attribute. Alternatively, I have been thinking whether {{style}} should be just
used and passed through...
Height and width would remain since they are still standalone attributes,
although we wire them into style because of Bootstrap's behavior, but that is
an implementation detail.
was (Author: michael-o):
I am inclined to drop the border attribute altogether since there are so many
aspects you can fiddle with CSS that is basically makes no sense to have one
attribute. Alternatively, I have been thinking whether {{style}} should be just
used and passed through...
> Clarify "border", "width" and "height" for Banner and LinkItem
> --------------------------------------------------------------
>
> Key: DOXIASITETOOLS-253
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-253
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Decoration model
> Reporter: Konrad Windszus
> Priority: Major
> Labels: doxia-2.0.0-stack
>
> The elements "border", "width" and "height" in
> #
> https://maven.apache.org/doxia/doxia-sitetools-archives/doxia-sitetools-1.11.1/doxia-decoration-model/decoration.html#class_bannerLeft
> #
> https://maven.apache.org/doxia/doxia-sitetools-archives/doxia-sitetools-1.11.1/doxia-decoration-model/decoration.html#class_bannerRight
> #
> https://maven.apache.org/doxia/doxia-sitetools-archives/doxia-sitetools-1.11.1/doxia-decoration-model/decoration.html#class_item
> have a very vague description (same in renamed doxia-site-model
> https://maven.apache.org/doxia/doxia-sitetools/doxia-site-model/site.html ).
> It should be clarified with regards to whether
> 1. this is the format of the same named CSS properties
> (https://www.w3.org/TR/CSS2/box.html#border-properties,
> https://www.w3.org/TR/CSS2/visudet.html#the-width-property and
> https://www.w3.org/TR/CSS2/visudet.html#the-height-property)
> 2. or the HTML4 attributes
> (https://www.w3.org/TR/html401/struct/objects.html#h-13.7.1 and
> https://www.w3.org/TR/html401/struct/objects.html#h-13.7.3)
> 3. or another custom format.
> Currently the skins use the values as-is for either CSS property or HTML
> attribute, but although they are named the same, the supported values differ
> a lot.
> This came up in the context of
> https://github.com/apache/maven-fluido-skin/pull/23#discussion_r866169720.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
