[
https://issues.apache.org/jira/browse/SCM-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738804#comment-17738804
]
Clemens Quoß edited comment on SCM-798 at 6/29/23 10:11 PM:
------------------------------------------------------------
I can pick this one up. It's not that i really have a current issue with this
but i do not like to have jira tickets lying around that could be fixed IMHO.
For this one i would propose this: Rename the tagBase parameter maven-scm wide
to sth. like copyBase or cpBase (maybe someone can come up with a better name -
but i think it would be OK as this parameter is only svn-related and copy is
the action used for tagging and branching in Subversion). With this generic
name this parameter can be used for tag and branch operations.
And then make this parameter also work on the branch goal.
WDYT?
Ah, but this of course breaks maven-release. But never mind. I could take care
of that as well. But that adds an external dependency. Both need to be released
synchroneously.
was (Author: cquoss):
I can pick this one up. It's not that i really have a current issue with this
but i do not like to have jira tickets lying around that could be fixed IMHO.
For this one i would propose this: Rename the tagBase parameter maven-scm wide
to sth. like copyBase or cpBase (maybe someone can come up with a better name -
but i think it would be OK as this parameter is only svn-related and copy is
the action used for tagging and branching in Subversion). With this generic
name this parameter can be used for tag and branch operations.
And then make this parameter also work on the branch goal.
WDYT?
> scm:branch ignores the tagBase parameter, there is no branchBase parameter
> --------------------------------------------------------------------------
>
> Key: SCM-798
> URL: https://issues.apache.org/jira/browse/SCM-798
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-plugin, maven-scm-provider-svn
> Affects Versions: 1.9.4
> Reporter: Jakub Bochenski
> Priority: Major
>
> {code}[DEBUG] Configuring mojo
> 'org.apache.maven.plugins:maven-scm-plugin:1.9.4:branch' with basic
> configurator -->
> [DEBUG] (f) basedir = /home/acme/gotham/common_ui
> [DEBUG] (f) branch = 2.2/2.2.0
> [DEBUG] (f) connectionType = connection
> [DEBUG] (s) connectionUrl =
> scm:svn:svn+ssh://s...@svn.acme.com/repos/trunk/common_ui
> [DEBUG] (f) developerConnectionUrl =
> scm:svn:svn+ssh://s...@svn.acme.com/repos/trunk/common_ui
> [DEBUG] (f) pushChanges = true
> [DEBUG] (f) remoteBranching = false
> [DEBUG] (f) settings = org.apache.maven.execution.SettingsAdapter@7b300cde
> [DEBUG] (f) tagBase = svn+ssh://s...@svn.acme.com/repos/branches/common_ui
> [DEBUG] -- end configuration --
> [INFO] Final Branch Name: '2.2/2.2.0'
> [INFO] Executing: /bin/sh -c cd /home/acme/gotham/common_ui && svn
> --non-interactive copy --file /tmp/maven-scm-1267210601.commit .
> svn+ssh://s...@svn.acme.com/repos/branches/2.2/2.2.0
> {code}
> I can see this code handling {{tagBase}}, but there is none for {{branchBase}}
> {code}
> if ( !StringUtils.isEmpty( tagBase ) &&
> repository.getProvider().equals( "svn" ) )
> {
> SvnScmProviderRepository svnRepo = (SvnScmProviderRepository)
> repository.getProviderRepository();
> svnRepo.setTagBase( tagBase );
> }{code}
> Adding a parallel handling for {{branchBase}} param should be trivial.
> Correcting the documentation is another thing -- the {{tagBase}} parameter is
> present on the base Mojo class even though it's ignored in some goals.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
