[GitHub] [maven] gnodet commented on a diff in pull request #1194: [MNG-6401] Support interpolation of the proxy port in settings.xml

[via GitHub]

gnodet commented on code in PR #1194:
URL: https://github.com/apache/maven/pull/1194#discussion_r1251331770


##########
api/maven-api-settings/src/main/mdo/settings.mdo:
##########
@@ -459,17 +459,19 @@
         The <code>&lt;proxy&gt;</code> element contains informations required 
to a proxy settings.
         ]]></description>
       <fields>
-        <field>
-          <name>active</name>
+        <field xml.tagName="active">
+          <name>activeString</name>
           <version>1.0.0+</version>
           <required>false</required>
           <defaultValue>true</defaultValue>
           <description>
             <![CDATA[

Review Comment:
   All descriptions in this file are enclosed in CDATA blocks, so while I don't 
mind removing those, I think it belongs in a separate PR.  I suppose the idea 
was to add CDATA blocks to all human readable texts and java code so that they 
don't have to be added/removed depending on the content.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org