[
https://issues.apache.org/jira/browse/MJAVADOC-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743109#comment-17743109
]
ASF GitHub Bot commented on MJAVADOC-763:
-----------------------------------------
elharo commented on code in PR #219:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/219#discussion_r1263627189
##########
src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java:
##########
@@ -594,27 +595,6 @@ public void testOptionsUmlautEncoding() throws Exception {
}
}
- /**
- * @throws Exception if any
- */
- public void testExceptions() throws Exception {
- try {
- Path testPom =
unit.resolve("default-configuration/exception-test-plugin-config.xml");
- JavadocReport mojo = lookupMojo(testPom);
Review Comment:
This lookup fails and throws an exception, causing the test to pass. It
never executes the mojo which is what it's supposed to test.
> JavadocReportTest.testExceptions is broken
> ------------------------------------------
>
> Key: MJAVADOC-763
> URL: https://issues.apache.org/jira/browse/MJAVADOC-763
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Reporter: Elliotte Rusty Harold
> Priority: Major
>
> The Mojo lookup fails. This is hidden by bad exception handling in the test
> that catches too broad an exception type.
> [ERROR] Errors:
> [ERROR]
> JavadocReportTest.testExceptions:603->lookupMojo:103->AbstractMojoTestCase.lookupMojo:355->AbstractMojoTestCase.lookupMojo:426
> ยป ComponentConfiguration Cannot load implementation hint
> 'org.apache.maven.plugins.javadoc.stubs.ExceptionTestMavenProjectStub'
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
