[
https://issues.apache.org/jira/browse/MRELEASE-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744569#comment-17744569
]
ASF GitHub Bot commented on MRELEASE-1054:
------------------------------------------
wuwen5 opened a new pull request, #196:
URL: https://github.com/apache/maven-release/pull/196
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MRELEASE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MRELEASE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MRELEASE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A
more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
As described in [MRELEASE-1054], when I use the Git submodule in a project,
`release: prepare` will fail. I really need to support the release of the Git
submodule, and I also have a pull request in the maven-scm project
https://github.com/apache/maven-scm/pull/179.
> [Git submodule] Wrong Change on scm submodule after release:prepare and
> failed on pushChange
> --------------------------------------------------------------------------------------------
>
> Key: MRELEASE-1054
> URL: https://issues.apache.org/jira/browse/MRELEASE-1054
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: Git, prepare, scm
> Affects Versions: 3.0.0-M1
> Reporter: Cau Ta
> Priority: Major
> Attachments: Screen Shot 2020-07-29 at 13.54.41.png
>
>
> *My project structure:*
> {{parent (git scm repo parent.git)}}
> {{-- git submodule A (git scm repo a.git)}}
> {{-- git submodule B (git scm repo b.git)}}
> {{-- git submodule C (git scm repo c.git)}}
> my maven release plugin config on parent pom.xml:
> _<plugin>_
> _<groupId>org.apache.maven.plugins</groupId>_
> _<artifactId>maven-release-plugin</artifactId>_
> _<version>3.0.0-M1</version>_
> _<configuration>_
> _<!-- <preparationGoals>deploy</preparationGoals>-->_
> _<tagNameFormat>v@\{project.version}</tagNameFormat>_
> _<autoVersionSubmodules>true</autoVersionSubmodules>_
> _<commitByProject>true</commitByProject>_
> _<allowTimestampedSnapshots>true</allowTimestampedSnapshots>_
> _<pushChanges>false</pushChanges>_
> _</configuration>_
> _</plugin>_
>
> The release was successful but after release:prepare the scm config of all
> submodule has been change.
> [Please take a look at the attachment]
> *--------------------------------------------------------------*
> *Another bug i have been faced is:*
> when enable push change (_<pushChanges>true</pushChanges>_)
> the release:prepare got stuck after push change at the first git submodule
> _[INFO] Executing: /bin/sh -c cd repository/beowulf/beowulf-libs/constant &&
> git push g...@github.com:beowulfchain-libs/beowulf-libs.git
> refs/heads/master:refs/heads/master_
> _[INFO] Working directory: repository/beowulf/beowulf-libs/constant_
> _[INFO]
> ------------------------------------------------------------------------_
> _[INFO] Reactor Summary for beowulf 1.0-SNAPSHOT:_
> _[INFO]_
> _[INFO] beowulf ............................................ FAILURE [
> 42.033 s]_
> _[INFO] constant ........................................... SKIPPED_
> _[INFO] core ............................................... SKIPPED_
> _[INFO] utils .............................................. SKIPPED_
> _[INFO] domain ............................................. SKIPPED_
> _[INFO] config ............................................. SKIPPED_
> _[INFO] logging ............................................ SKIPPED_
> _[INFO]
> ------------------------------------------------------------------------_
> _[INFO] BUILD FAILURE_
> _[INFO]
> ------------------------------------------------------------------------_
> _[INFO] Total time: 42.709 s_
> _[INFO] Finished at: 2020-07-28T17:51:04+07:00_
> _[INFO]
> ------------------------------------------------------------------------_
> _[ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M1:prepare (default-cli)
> on project beowulf: Unable to commit files_
> _[ERROR] Provider message:_
> _[ERROR] The git-push command failed._
> _[ERROR] Command output:_
> _[ERROR] Warning: Permanently added the RSA host key for IP address
> 'xxx.xxx.xxx.3' to the list of known hosts._
> _[ERROR] To github.com:beowulfchain-libs/beowulf-libs.git_
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
