[
https://issues.apache.org/jira/browse/MNG-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746150#comment-17746150
]
ASF GitHub Bot commented on MNG-7851:
-------------------------------------
candrews opened a new pull request, #1210:
URL: https://github.com/apache/maven/pull/1210
[MNG-7851](https://issues.apache.org/jira/browse/MNG-7851) Improve error
message when modelVersion is 4.0
Improve `DefaultModelValidator.compareModelVersions` to be able to compare
versions which different numbers of segments, allowing it to compare "4",
"4.0", and "4.0.0" to each other for example.
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA
issue.
- [X] Also format the first line of the commit message like `[MNG-XXX]
SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request
title and in the first line of the commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [X] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> Error message when modelVersion is 4.0 is confusing
> ---------------------------------------------------
>
> Key: MNG-7851
> URL: https://issues.apache.org/jira/browse/MNG-7851
> Project: Maven
> Issue Type: Bug
> Components: Core
> Affects Versions: 3.9.3
> Reporter: Craig
> Priority: Minor
>
> When a pom with modelVersion 4.0 is referenced, such as this one:
> {code:xml}
> <project>
> <modelVersion>4.0</modelVersion>
> <groupId>foo</groupId>
> <artifactId>bar</artifactId>
> <version>0.1</version>
> </project>
> {code}
> The error message is:
> {{'modelVersion' of '4.0' is newer than the versions supported by this
> version of Maven: [4.0.0]. Building this project requires a newer version of
> Maven.}}
>
> That's misleading.
> A better error message would be:
> {{'modelVersion' must be one of [4.0.0] but is '4.0'.}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
