[
https://issues.apache.org/jira/browse/MNG-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757215#comment-17757215
]
ASF GitHub Bot commented on MNG-7851:
-------------------------------------
gnodet commented on PR #1210:
URL: https://github.com/apache/maven/pull/1210#issuecomment-1687527207
> If we're going litteral, shouldn't we simply check that the version in the
model is one of the supported version. The `validateModelVersion` could be
simplified to just check the version is supported or thrown an exception
without having to check for newer / older versions.
@candrews could you simplify the code for the
[`validateModelVersion`](https://github.com/apache/maven/blob/78da8ff662d9c9e0ba87aa2138114d8fd393855c/maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java#L1383-L1460)
method so that it simply checks if the version is in the provided set instead
(third branch of the tests) instead of comparing with all other versions ?
> Error message when modelVersion is 4.0 is confusing
> ---------------------------------------------------
>
> Key: MNG-7851
> URL: https://issues.apache.org/jira/browse/MNG-7851
> Project: Maven
> Issue Type: Bug
> Components: Core
> Affects Versions: 3.9.3
> Reporter: Craig
> Priority: Minor
>
> When a pom with modelVersion 4.0 is referenced, such as this one:
> {code:xml}
> <project>
> <modelVersion>4.0</modelVersion>
> <groupId>foo</groupId>
> <artifactId>bar</artifactId>
> <version>0.1</version>
> </project>
> {code}
> The error message is:
> {{'modelVersion' of '4.0' is newer than the versions supported by this
> version of Maven: [4.0.0]. Building this project requires a newer version of
> Maven.}}
>
> That's misleading.
> A better error message would be:
> {{'modelVersion' must be one of [4.0.0] but is '4.0'.}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
