[
https://issues.apache.org/jira/browse/MJAVADOC-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763214#comment-17763214
]
ASF GitHub Bot commented on MJAVADOC-758:
-----------------------------------------
hgschmie opened a new pull request, #230:
URL: https://github.com/apache/maven-javadoc-plugin/pull/230
Throw NPE, not IOException
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MJAVADOC-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A
more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
> IOException --> NullPointerException in JavadocUtil.copyResource
> ----------------------------------------------------------------
>
> Key: MJAVADOC-758
> URL: https://issues.apache.org/jira/browse/MJAVADOC-758
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Reporter: Elliotte Rusty Harold
> Priority: Minor
>
> These are not IOExceptions. They are null pointers
> {{
> protected static void copyResource(URL url, File file) throws IOException
> {
> if (file == null) {
> throw new IOException("The file can't be null.");
> }
> if (url == null) {
> throw new IOException("The url could not be null.");
> }
> FileUtils.copyURLToFile(url, file);
> }}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
