[ 
https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763263#comment-17763263
 ] 

ASF GitHub Bot commented on MJAVADOC-642:
-----------------------------------------

hgschmie commented on code in PR #232:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/232#discussion_r1320341278


##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -334,9 +334,11 @@ public abstract class AbstractJavadocMojo extends 
AbstractMojo {
 
     /**
      * Specify if the Javadoc should operate in offline mode.
+     *
+     * @since 3.5.1
      */
-    @Parameter(defaultValue = "${settings.offline}", required = true, readonly 
= true)
-    private boolean isOffline;
+    @Parameter(alias = "isOffline", property = "maven.javadoc.offline", 
defaultValue = "false")
+    private boolean offline;

Review Comment:
   ok. 
   





> Setting maven.javadoc.isoffline seems to have no effect
> -------------------------------------------------------
>
>                 Key: MJAVADOC-642
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-642
>             Project: Maven Javadoc Plugin
>          Issue Type: Bug
>          Components: jar
>    Affects Versions: 3.1.1
>            Reporter: Thomas Cunningham
>            Priority: Major
>             Fix For: wontfix-candidate, waiting-for-feedback
>
>
> I'm trying to work around MJAVADOC-641 and the proxy issues that we are 
> having, and I'd like to set isOffline to true.     I tried to do this my 
> setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't 
> seem to take effect.    Setting isOffline to true within the <configuration/> 
> allows my build to succeed.
> Am I using the wrong command line property for isOffline?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to