[ 
https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763958#comment-17763958
 ] 

ASF GitHub Bot commented on MNG-7864:
-------------------------------------

gnodet commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1322129967


##########
Jenkinsfile.s390x.its:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+  agent { node { 's390x' } }
+  options {
+    durabilityHint('PERFORMANCE_OPTIMIZED')
+    buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+    timeout(time: 180, unit: 'MINUTES')
+  }
+  parameters {
+    string( defaultValue: 'master', description: 'Core Its branch (default 
master)',
+            name: 'ITS_BRANCH' )

Review Comment:
   What's the actual value for this parameter ? It should be computed, but I 
don't really see any computation in this file.





> Fix the S390x to use IT branches
> --------------------------------
>
>                 Key: MNG-7864
>                 URL: https://issues.apache.org/jira/browse/MNG-7864
>             Project: Maven
>          Issue Type: Bug
>            Reporter: Guillaume Nodet
>            Priority: Major
>
> When testing a PR, the maven-integration-testing branch with the same name 
> should be used instead of master if it exists.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to