[
https://issues.apache.org/jira/browse/MNG-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767671#comment-17767671
]
ASF GitHub Bot commented on MNG-7541:
-------------------------------------
JurrianFahner commented on PR #982:
URL: https://github.com/apache/maven/pull/982#issuecomment-1730072787
> > > As a matter of fact, this implemenation should copy the approach from
mvn.cmd from master, not from maven-3.9.x. It does not matter to add something
new and then skim a bit later. Then it would be back ported to 3.9.x as-is
logically.
> >
> >
> > Wouldn't it not be better to get
[master](https://github.com/apache/maven/pull/878) reviewed first and then
retrofit the approach in master to the 3.9.x branch? Please be aware that there
will be two different approaches in the component.xml, which makes reviewing a
little bit harder.
>
> True, but the content of the script won't change, only its arrangement.
Ok, in that case we are aligned. I'll update the master branch with the
improvements on this branch. When the master is merged, I'll retrofit the
changes into this branch.
@Giovds Are you available for reviewing the master PR? I first need to apply
the changes on this branch to the master (#878).
> Native support for PowerShell to start Maven
> --------------------------------------------
>
> Key: MNG-7541
> URL: https://issues.apache.org/jira/browse/MNG-7541
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
> Affects Versions: 3.8.3
> Environment: windows 10 / 11
> Reporter: Jurrian Fahner
> Priority: Trivial
> Labels: Script, Windows10, Windows11
>
> Maven has two files in the bin dir:
> ||command||its use||
> |mvn|POSIX shell|
> |mvn.cmd|cmd.exe|
> On windows there are two ways to write scripts, by using cmd.exe or using
> powershell.
> If you enter mvn in powershell it will look for `mvn.ps1` on the PATH first.
> If it doesn't find anything it will execute `mvn.cmd` as fall-back.
> When running maven for starting a server for development purposes and you do
> ctrl-c to exit the server it will ask the question: Terminate batch job (Y/N)?
> As far as I know it is default behaviour of cmd.exe.
> Well if I don't want to terminate, I wouldn't press ctrl-c. ;)
> It is not the case (as far as I know that Microsoft is going to deprecate
> cmd.exe in favor of powershell:
> [https://devblogs.microsoft.com/commandline/rumors-of-cmds-death-have-been-greatly-exaggerated/]
> Allthough I think it would be a good move for maven to have also a powershell
> script as well... It is possible to integrate elegant support for native help
> in powershell, `get-help mvn`.
> But it also increases the maintenance effort as well. I don't know whether
> this cost outweigh the benefits, though...
> By the way I would happy to contribute if it is appreciated.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
