sebastien-doyon commented on code in PR #1270:
URL: https://github.com/apache/maven/pull/1270#discussion_r1340453474
##########
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -495,19 +495,6 @@ void logging(CliRequest cliRequest) {
cliRequest.quiet = !cliRequest.verbose &&
commandLine.hasOption(CLIManager.QUIET);
cliRequest.showErrors = cliRequest.verbose ||
commandLine.hasOption(CLIManager.ERRORS);
- slf4jLoggerFactory = LoggerFactory.getILoggerFactory();
Review Comment:
Well, the MessageUtils.setColorEnabled must be called before calling
slf4jConfiguration.setRootLoggerLevel witch load for the first time the
MavenSimpleLogger class. Since this modified class use now static constants,
its is necessary that the colour support is set right before loading the
MavenSimpleLogger class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
