mthmulders commented on code in PR #311: URL: https://github.com/apache/maven-integration-testing/pull/311#discussion_r1358476213
########## core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7772CoreExtensionsNotFoundTest.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.it; + +import java.io.ByteArrayOutputStream; +import java.io.File; +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; + +import org.apache.maven.shared.verifier.VerificationException; +import org.apache.maven.shared.verifier.Verifier; +import org.apache.maven.shared.verifier.util.ResourceExtractor; +import org.junit.jupiter.api.Test; + +/** + * This is a test set for <a href="https://issues.apache.org/jira/browse/MNG-7772";>MNG-7772</a>: + * check that Maven fails if it cannot load core extensions contributed by <code>${user.home}/.m2/extensions.xml</code>. + */ +public class MavenITmng7772CoreExtensionsNotFoundTest extends AbstractMavenIntegrationTestCase { + + public MavenITmng7772CoreExtensionsNotFoundTest() { + super("[3.9.0,)"); + } + + @Test + public void testCoreExtensionsNotFound() throws Exception { + File testDir = ResourceExtractor.simpleExtractResources(getClass(), "/mng-7772-core-extensions-not-found"); + + Path m2TestDirPath = Paths.get(testDir.toPath().toString(), ".m2"); + Files.createDirectories(Paths.get(System.getProperty("user.home"), ".m2")); Review Comment: I'm not 100% sure this is the location of the Maven user directory in the Core Integration Suite. I hope someone else knows for sure.... ########## core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7772CoreExtensionsNotFoundTest.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.it; + +import java.io.ByteArrayOutputStream; +import java.io.File; +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; + +import org.apache.maven.shared.verifier.VerificationException; +import org.apache.maven.shared.verifier.Verifier; +import org.apache.maven.shared.verifier.util.ResourceExtractor; +import org.junit.jupiter.api.Test; + +/** + * This is a test set for <a href="https://issues.apache.org/jira/browse/MNG-7772";>MNG-7772</a>: + * check that Maven fails if it cannot load core extensions contributed by <code>${user.home}/.m2/extensions.xml</code>. + */ +public class MavenITmng7772CoreExtensionsNotFoundTest extends AbstractMavenIntegrationTestCase { + + public MavenITmng7772CoreExtensionsNotFoundTest() { + super("[3.9.0,)"); Review Comment: Since your change on Maven itself is on the **master** branch, I'd expect the version range to start with "4.0.0-alpha-8". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
